-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove maxRecentReportsToShow limit for categorize and share actions for track expense #41009
remove maxRecentReportsToShow limit for categorize and share actions for track expense #41009
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
cc: @thienlnam |
Reviewer Checklist
Screenshots/VideosAndroid: NativeUploading VIDEO-2024-04-26-01-10-05.mp4… Android: mWeb ChromeVIDEO-2024-04-26-01-10-05.mp4iOS: NativeScreen.Recording.2024-04-26.at.12.56.42.AM.moviOS: mWeb SafariRPReplay_Final1714073502.MP4MacOS: Chrome / SafariScreen.Recording.2024-04-26.at.12.46.42.AM-1.movMacOS: DesktopScreen.Recording.2024-04-26.at.1.15.33.AM-1.mov |
This comment was marked as resolved.
This comment was marked as resolved.
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.67-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
|
Details
Categorize it
option for a track expense shows only 5 recent reports. Since only recent reports are shown here and all recent reports are only workspaces, the maximum limit for recent reports to show is removed.searchInServer
searches only for reports available in the backend. So the workspaces created during this time are not available in the options shown nor can be searched from the search input. So, removing the limit makes all the workspace options available here.Fixed Issues
$ #40406 (comment)
PROPOSAL: #40406 (comment) and the following comments and Slack discussion here
https://expensify.slack.com/archives/C01GTK53T8Q/p1714060064151559
Tests
Same as QA steps
Offline tests
Same as QA steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
maxReportsAndroid.mp4
Android: mWeb Chrome
iOS: Native
maxReportsiOS.mp4
iOS: mWeb Safari
maxReportsiOSSafari.mp4
MacOS: Chrome / Safari
maxReportsChrome.mp4
MacOS: Desktop
maxReportsDesktop.mp4